dlmarion commented on PR #4206:
URL: https://github.com/apache/accumulo/pull/4206#issuecomment-1919554293

   > This branch had ColumnVis wrap and AccessExpression. In 
https://github.com/apache/accumulo/pull/3746 ColVis was still wrapping a byte 
array instead of an AccessExpress. I kept the byte[] to avoid going from 
byte[]->String->byte[] in some cases. Also avoid an extra object allocation in 
some cases. However I am not sure about this. Wrapping the AccessExpression 
seems cleaner, but may be inefficient in some circumstances w/ more copies and 
object allocations.
   
   I made a comment on apache/accumulo#3746 regarding this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to