keith-turner commented on PR #4206: URL: https://github.com/apache/accumulo/pull/4206#issuecomment-1920241738
> I liked the simplicity of ColVis wrapping AccessExpression. The VisibilityEvaluator is changing to use AccessEvaluator, so the byte[] in ColVis must be a valid AccessExpression. In ColVis(byte[]) constructor, you are calling AccessExpression.validate, so I'm not sure that you are saving much w/r/t object creation. I wonder if the answer is for ColVis to have AccessExpression and byte[] members that are set in the constructor to avoid the runtime cost of calling AccessExpression.getExpression. I like ColVis wrapping AccessExpression too. I have not fully worked this out, but wondering if another piece of this puzzle is deprecating `byte[] getExpression()` and replacing it with `AccessExpression getAccessExpression()` in ColVis. Not sure about that though, would need to try to know what the implications are. When thinking of that deprecation, I started to wondering about a more general deprecation. Could AccessExpression replace ColVis completely in the Accumulo API, I get completely lost when thinking through that though because there are so many things to consider. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
