EdColeman commented on code in PR #4208:
URL: https://github.com/apache/accumulo/pull/4208#discussion_r1483332945
##########
server/manager/src/main/java/org/apache/accumulo/manager/tableOps/tableImport/PopulateMetadataTable.java:
##########
@@ -155,11 +166,7 @@ public Repo<Manager> call(long tid, Manager manager)
throws Exception {
if (m == null || !currentRow.equals(metadataRow)) {
if (m != null) {
- if (!sawTabletAvailability) {
- // add a default tablet availability
- TabletColumnFamily.AVAILABILITY_COLUMN.put(m,
-
TabletAvailabilityUtil.toValue(TabletAvailability.ONDEMAND));
- }
+ AVAILABILITY_COLUMN.put(m,
TabletAvailabilityUtil.toValue(initialAvailability));
Review Comment:
My preference:
Always set all tables to ondemand on import - unless the import command
allows the user to specifically set a different, desired state. If the user
knows what they want, it would be nice if they did not have to go through two
steps to set the goal. It should be a uniform state though, all ondemand or
all something else. If they want specific ranges, that might require two steps,
(import, set-state). The default, unless specified otherwise by the user
should be ondemand.
The state should not be included in the export data. If it must be, it
should be ignored on import.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
