keith-turner commented on code in PR #4208:
URL: https://github.com/apache/accumulo/pull/4208#discussion_r1476794442


##########
server/manager/src/main/java/org/apache/accumulo/manager/tableOps/tableImport/PopulateMetadataTable.java:
##########
@@ -155,11 +166,7 @@ public Repo<Manager> call(long tid, Manager manager) 
throws Exception {
             if (m == null || !currentRow.equals(metadataRow)) {
 
               if (m != null) {
-                if (!sawTabletAvailability) {
-                  // add a default tablet availability
-                  TabletColumnFamily.AVAILABILITY_COLUMN.put(m,
-                      
TabletAvailabilityUtil.toValue(TabletAvailability.ONDEMAND));
-                }
+                AVAILABILITY_COLUMN.put(m, 
TabletAvailabilityUtil.toValue(initialAvailability));

Review Comment:
   > I think the distinction will come down to how availability is perceived. 
Is it an inherent property of a table, or is it more closely related to the 
system and environment. Things like splits, table properties seem closely tied 
to the table and the data. It may be that availability does not have that same 
affinity - it is more dependent on the system environment at any particular 
point in time.
   
   It definitely fits into more of a runtime/execution aspect of the tablets 
metadata like table location, external compaction ids, scan refs, etc.  Where 
other parts of the tablet metadata are more related to the table data like the 
range, file list, wals, next tablet timestamp, etc



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to