kevinrr888 commented on PR #4247: URL: https://github.com/apache/accumulo/pull/4247#issuecomment-1944439283
Completed review changes: - FateId refactored (better Pattern for FateId and simpler validation) - CompactionMetadata GSonData changed to use the canonical FateId string instead of FateId (note that old data may need to be considered here) - SelectedFiles renamed "txid" --> "fateId". SelectedFilesTest updated to be consistent with changes - CompactionConfigStorage added Preconditions check - Changed compactionHints in TabletManagementParameters from Map<FateId,Map<String,String>> --> Map<String,Map<String,String>>: required changes to TabletManagementParameters, CompactionConfigStorage, CompactionJobGenerator, TabletManagementParametersTest, Manager, CancelCompactions, and PreDeleteTable - AmpleConditionalWriterIT.testCompacted() reordering of FateIds -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
