kevinrr888 commented on PR #4247: URL: https://github.com/apache/accumulo/pull/4247#issuecomment-1944509944
> > Changed compactionHints in TabletManagementParameters from Map<FateId,Map<String,String>> --> Map<String,Map<String,String>>: required changes to TabletManagementParameters, CompactionConfigStorage, CompactionJobGenerator, TabletManagementParametersTest, Manager, CancelCompactions, and PreDeleteTable > > Sorry I did not communicate very clearly for the comment about that. Was not looking to change the external map type parameters for TabletManagementParameters to have a key type of String. Just thought it would be good to change internal map used for json so that the json encoding would cleaner. So was thinking of pattern like the following. > > * The public methods on TabletManagementParameters use `Map<FateId,Map<String,String>>` > * Internally for json encoding `Map<FateId,Map<String,String>>` is converted to/from `Map<String,Map<String,String>>` Ah gotcha. Will fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
