dlmarion commented on code in PR #4287:
URL: https://github.com/apache/accumulo/pull/4287#discussion_r1499184896
##########
server/manager/src/main/java/org/apache/accumulo/manager/TabletGroupWatcher.java:
##########
@@ -680,7 +682,7 @@ public void run() {
iter = store.iterator(tableMgmtParams);
var tabletMgmtStats = manageTablets(iter, tableMgmtParams,
currentTServers, true);
- lookForTabletsNeedingVolReplacement =
tabletMgmtStats.totalVolumeReplacements != 0;
+ lookForTabletsNeedingVolReplacement =
tabletMgmtStats.totalVolumeReplacements != 0 ||
tabletMgmtStats.tabletsWithErrors != 0;
Review Comment:
```suggestion
// Continue to look for tablets needing volume replacement if there
was an error processing
// tablets in the call to manageTablets() or if we are still
performing volume replacement. We
// only want to stop looking for tablets that need volume
replacement when we have successfully
// processed all tablet metadata and no more volume replacements are
being performed.
lookForTabletsNeedingVolReplacement =
tabletMgmtStats.totalVolumeReplacements != 0 ||
tabletMgmtStats.tabletsWithErrors != 0;
```
##########
server/manager/src/main/java/org/apache/accumulo/manager/TabletGroupWatcher.java:
##########
@@ -398,6 +399,7 @@ private TableMgmtStats
manageTablets(Iterator<TabletManagement> iter,
"Error on TabletServer trying to get Tablet management information
for extent: {}. Error message: {}",
tm.getExtent(), mtiError);
this.metrics.incrementTabletGroupWatcherError(this.store.getLevel());
Review Comment:
This line increments the metric that indicates that an error occurred in the
TabletGroupWatcher.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
