keith-turner commented on code in PR #4287:
URL: https://github.com/apache/accumulo/pull/4287#discussion_r1503107649
##########
server/manager/src/main/java/org/apache/accumulo/manager/TabletGroupWatcher.java:
##########
@@ -680,7 +682,7 @@ public void run() {
iter = store.iterator(tableMgmtParams);
var tabletMgmtStats = manageTablets(iter, tableMgmtParams,
currentTServers, true);
- lookForTabletsNeedingVolReplacement =
tabletMgmtStats.totalVolumeReplacements != 0;
+ lookForTabletsNeedingVolReplacement =
tabletMgmtStats.totalVolumeReplacements != 0 ||
tabletMgmtStats.tabletsWithErrors != 0;
Review Comment:
If we are not currently looking for volume replacements and there is an
error, then we may start looking for them. Once we have stopped looking for
them we do not need to start again even if there is an error. Could add an if
for this.
```suggestion
// If currently looking for volume replacements, determine if the
next round needs to look.
if(lookForTabletsNeedingVolReplacement){
// TODO add the suggested comment from @dlmarion here
lookForTabletsNeedingVolReplacement =
tabletMgmtStats.totalVolumeReplacements != 0 ||
tabletMgmtStats.tabletsWithErrors != 0;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
