dlmarion commented on code in PR #4296:
URL: https://github.com/apache/accumulo/pull/4296#discussion_r1500598319
##########
server/manager/src/main/java/org/apache/accumulo/manager/compaction/queue/CompactionJobPriorityQueue.java:
##########
@@ -130,6 +131,10 @@ public synchronized boolean add(TabletMetadata
tabletMetadata, Collection<Compac
CjpqKey cjqpKey = addJobToQueue(tabletMetadata, job);
if (cjqpKey != null) {
newEntries.add(cjqpKey);
+ } else {
+ // The priority for this job was lower than all other priorities and
not added
+ // In this case we will return true even though a subset of the jobs,
or none,
+ // were added
Review Comment:
@keith-turner - I was curious about your thoughts on this comment. Do we
still want to return true if nothing is added? Do we still want to return true
if only a subset of the jobs are added? If we are only returning a different
value when the queue is closed, maybe we should return this to return nothing
(`void`) and throw an IllegalStateException?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
