dlmarion commented on code in PR #4296:
URL: https://github.com/apache/accumulo/pull/4296#discussion_r1504268227
##########
server/manager/src/main/java/org/apache/accumulo/manager/compaction/queue/CompactionJobPriorityQueue.java:
##########
@@ -130,6 +131,10 @@ public synchronized boolean add(TabletMetadata
tabletMetadata, Collection<Compac
CjpqKey cjqpKey = addJobToQueue(tabletMetadata, job);
if (cjqpKey != null) {
newEntries.add(cjqpKey);
+ } else {
+ // The priority for this job was lower than all other priorities and
not added
+ // In this case we will return true even though a subset of the jobs,
or none,
+ // were added
Review Comment:
Implemented this in fa54445
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
