keith-turner commented on code in PR #4309:
URL: https://github.com/apache/accumulo/pull/4309#discussion_r1505158263
##########
core/src/main/java/org/apache/accumulo/core/clientImpl/ClientContext.java:
##########
@@ -249,6 +251,27 @@ public ClientContext(SingletonReservation reservation,
ClientInfo info,
clientThreadPools = ThreadPools.getClientThreadPools(ueh);
}
}
+ // Kick off a task to try and populate the ZooCache with TabletServer
+ // information. It may not be complete as the cluster may be starting.
+ // It's a best effort
+ clientThreadPools
Review Comment:
> You are suggesting that we don't need to preload ZooCache?
Thinking in a client instance that is busy that eventually the cache will be
populated. On a client that is not busy the cache will not be populated, but
thats ok it does not need the data.
> Do you think there is a downside to removing this?
There may be a downside, but can not think of something specific. Thinking
we are not sure if there is an upside and the behavior could cause uneeded ZK
load, so maybe its ok to omit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
