dlmarion commented on code in PR #4309:
URL: https://github.com/apache/accumulo/pull/4309#discussion_r1506070505
##########
core/src/main/java/org/apache/accumulo/core/rpc/clients/TServerClient.java:
##########
@@ -57,44 +60,54 @@ default Pair<String,C> getTabletServerConnection(Logger
LOG, ThriftClientTypes<C
ClientContext context, boolean preferCachedConnections, AtomicBoolean
warned)
throws TTransportException {
checkArgument(context != null, "context is null");
- long rpcTimeout = context.getClientTimeoutInMillis();
- // create list of servers
- ArrayList<ThriftTransportKey> servers = new ArrayList<>();
+ final long rpcTimeout = context.getClientTimeoutInMillis();
- // add tservers
- ZooCache zc = context.getZooCache();
- for (String tserver : zc.getChildren(context.getZooKeeperRoot() +
Constants.ZTSERVERS)) {
- var zLocPath =
- ServiceLock.path(context.getZooKeeperRoot() + Constants.ZTSERVERS +
"/" + tserver);
- byte[] data = zc.getLockData(zLocPath);
- if (data != null) {
- String strData = new String(data, UTF_8);
- if (!strData.equals("manager")) {
- servers.add(new ThriftTransportKey(
- new ServerServices(strData).getAddress(Service.TSERV_CLIENT),
rpcTimeout, context));
+ final ZooCache zc = context.getZooCache();
+ final List<String> tservers = new ArrayList<>();
+ final AtomicBoolean warnedAboutTServersBeingDown = new
AtomicBoolean(false);
Review Comment:
Good catch. I used the warn variable in aecd790
##########
core/src/main/java/org/apache/accumulo/core/clientImpl/ClientContext.java:
##########
@@ -249,6 +251,27 @@ public ClientContext(SingletonReservation reservation,
ClientInfo info,
clientThreadPools = ThreadPools.getClientThreadPools(ueh);
}
}
+ // Kick off a task to try and populate the ZooCache with TabletServer
+ // information. It may not be complete as the cluster may be starting.
+ // It's a best effort
+ clientThreadPools
Review Comment:
I removed this in in aecd790
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
