ddanielr commented on PR #4487: URL: https://github.com/apache/accumulo/pull/4487#issuecomment-2072361877
> No issue with this change. However, I think `Property.fixedProperties` needs to be reviewed. There are properties that we are marking as mutable by using the prefix property that require a restart, but are not in the `fixedProperties` set. For example, `tserver.server.threads.minimum` is marked mutable, so it can be changed in ZK, but the TServer will not update it's internal value and restart the Thrift Server. Looking at this, should all the properties that are used as arguments to `TServerUtils.startServer` be considered fixed? https://github.com/apache/accumulo/blob/361ed50211a215e955fb84118280b0cb92743aa3/server/base/src/main/java/org/apache/accumulo/server/rpc/TServerUtils.java#L131-L135 If so I can make updates to `Property.fixedProperties` for the various missing properties. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
