dlmarion commented on code in PR #4487:
URL: https://github.com/apache/accumulo/pull/4487#discussion_r1576514313
##########
core/src/main/java/org/apache/accumulo/core/conf/Property.java:
##########
@@ -1832,11 +1832,29 @@ public static boolean isValidTablePropertyKey(String
key) {
public static final EnumSet<Property> fixedProperties = EnumSet.of(
// port options
- GC_PORT, MANAGER_CLIENTPORT, TSERV_CLIENTPORT,
+ GC_PORT, MANAGER_CLIENTPORT, TSERV_CLIENTPORT, SSERV_CLIENTPORT,
SSERV_PORTSEARCH,
+ COMPACTOR_PORTSEARCH, TSERV_PORTSEARCH,
- // tserver cache options
+ // max message options
+ SSERV_MAX_MESSAGE_SIZE, TSERV_MAX_MESSAGE_SIZE,
COMPACTOR_MAX_MESSAGE_SIZE,
+ COMPACTION_COORDINATOR_MAX_MESSAGE_SIZE,
+
+ // cache options
TSERV_CACHE_MANAGER_IMPL, TSERV_DATACACHE_SIZE, TSERV_INDEXCACHE_SIZE,
- TSERV_SUMMARYCACHE_SIZE,
+ TSERV_SUMMARYCACHE_SIZE, SSERV_DATACACHE_SIZE, SSERV_INDEXCACHE_SIZE,
SSERV_SUMMARYCACHE_SIZE,
+ SSERV_CACHED_TABLET_METADATA_EXPIRATION,
Review Comment:
`SSERV_CACHED_TABLET_METADATA_EXPIRATION` could be moved down to `sserver
specific options`. It's not one of the properties for the block caches.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
