DomGarguilo commented on code in PR #4452:
URL: https://github.com/apache/accumulo/pull/4452#discussion_r1580081949
##########
test/src/main/java/org/apache/accumulo/test/compaction/ExternalCompactionProgressIT.java:
##########
@@ -148,6 +230,10 @@ private void checkRunning() throws TException {
progressList.add(EC_PROGRESS.HALF);
} else if (rci.progress > 75 && rci.progress <= 100) {
progressList.add(EC_PROGRESS.THREE_QUARTERS);
+ } else {
+ progressList.add(EC_PROGRESS.INVALID);
+ log.warn("An invalid progress {} has been seen. This should
never occur.",
+ rci.progress);
Review Comment:
I think it would be nice to either fail the test here instead of adding it
to the list (quicker runtime), or where all the progress states are checked at
the end, check them all by using Junits `assertAll()` that way it will alert us
if multiple asserts fail instead of just stop at the first failure (more
coverage).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
