kevinrr888 commented on code in PR #4452:
URL: https://github.com/apache/accumulo/pull/4452#discussion_r1583123340
##########
test/src/main/java/org/apache/accumulo/test/compaction/ExternalCompactionProgressIT.java:
##########
@@ -148,6 +230,10 @@ private void checkRunning() throws TException {
progressList.add(EC_PROGRESS.HALF);
} else if (rci.progress > 75 && rci.progress <= 100) {
progressList.add(EC_PROGRESS.THREE_QUARTERS);
+ } else {
+ progressList.add(EC_PROGRESS.INVALID);
+ log.warn("An invalid progress {} has been seen. This should
never occur.",
+ rci.progress);
Review Comment:
Changed to use `assertAll()`. Could have it fail for that specific check
there, but we already need to add to a list for the other checks (or at least
some way to signal that those progresses have been seen), so I think it is more
consistent to just add INVALID to the list. This way also won't end the
progress early, which may be better for debugging to see how high the progress
goes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
