cshannon commented on PR #4486:
URL: https://github.com/apache/accumulo/pull/4486#issuecomment-2079923567

   @dlmarion - A couple more things:
   
   1. I am going to open a PR with my branch against your PR to make it easier 
to look at, but I noticed that the testFiles() test inside 
AmpleConditionalWriterIT is failing with this change here (without my changes 
as well) so I wanted to look at that.
   2. I took a look at using BiFunction instead of two functions but I don't 
think that will work as that does the opposite of what we need. BiFunction 
takes 2 inputs and outputs 1 result but we need 1 input (the column) and to 
output 2 results (a key and value) that the iterator can concatenate 
transparently to the user when building the condition.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to