keith-turner commented on code in PR #4486:
URL: https://github.com/apache/accumulo/pull/4486#discussion_r1596004345
##########
server/base/src/main/java/org/apache/accumulo/server/metadata/iterators/SetEncodingIterator.java:
##########
@@ -139,6 +161,7 @@ public boolean hasTop() {
public void init(SortedKeyValueIterator<Key,Value> source,
Map<String,String> options,
IteratorEnvironment env) throws IOException {
this.source = source;
+ this.concat = Boolean.parseBoolean(options.getOrDefault(CONCAT_VALUE,
Boolean.toString(false)));
Review Comment:
This option should always be set, so could throw an exception if its not
present. Following would throw an NPE, could do something else that creates an
exception w/ a nice error message.
```suggestion
this.concat = Boolean.parseBoolean(options.get(CONCAT_VALUE));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
