dlmarion commented on code in PR #4471:
URL: https://github.com/apache/accumulo/pull/4471#discussion_r1595934902
##########
server/manager/src/main/java/org/apache/accumulo/manager/Manager.java:
##########
@@ -934,7 +940,11 @@ private long balanceTablets() {
synchronized (balancedNotifier) {
balancedNotifier.notifyAll();
}
+ balancerMetrics.setMigratingCount(0);
+ balancerMetrics.setNeedMigrationCount(0);
} else {
+ balancerMetrics.setMigratingCount(params.migrationsOut().size());
+ balancerMetrics.setNeedMigrationCount(migrations.size());
Review Comment:
I believe that the `migrations` variable in the Manager contains all of the
in-flight migrations. The `params.migrationsOut` contains the tablets that need
to be migrated from this call to the balancer. I think based on what I'm seeing
here, it's double counting. I wonder if we just want the size of the
`migrations` list as that will encompass newly added, newly removed, and
migrations waiting to happen.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
