dlmarion commented on code in PR #4471:
URL: https://github.com/apache/accumulo/pull/4471#discussion_r1595944640


##########
server/manager/src/main/java/org/apache/accumulo/manager/Manager.java:
##########
@@ -934,7 +940,11 @@ private long balanceTablets() {
         synchronized (balancedNotifier) {
           balancedNotifier.notifyAll();
         }
+        balancerMetrics.setMigratingCount(0);
+        balancerMetrics.setNeedMigrationCount(0);
       } else {
+        balancerMetrics.setMigratingCount(params.migrationsOut().size());
+        balancerMetrics.setNeedMigrationCount(migrations.size());

Review Comment:
   If you want to capture the newly added migrations, then it might make sense 
to capture the migration completions (which are in the TabletGroupWatcher) and 
cancellations (which happen in a couple places in the Manager).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to