dlmarion commented on PR #4558: URL: https://github.com/apache/accumulo/pull/4558#issuecomment-2118248637
> I left a few comments, primarily around how the cache is implemented and used I think should be changed. But the other big thing is I am thinking this custom logic would be better implemented using the [Filter](https://logging.apache.org/log4j/2.x/manual/extending.html#filters) API that is part of log4j2. I think we could create a custom filter and put the conditional logic in there instead of having to implement a new ConditionalLogger class. The nice thing about a filter too is it is configurable at runtime easily. But we are coding to the slf4j api. A user using log4j2 is a deployment decision, someone could swap it out for logback or something else. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
