cshannon commented on code in PR #4558:
URL: https://github.com/apache/accumulo/pull/4558#discussion_r1605563126
##########
server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java:
##########
@@ -164,9 +167,10 @@ public long getDataSourceDeletions() {
}
private enum CloseState {
- OPEN, CLOSING, CLOSED, COMPLETE
+ OPEN, REQUESTED, CLOSING, CLOSED, COMPLETE
}
+ private volatile long closeRequestTime = 0;
Review Comment:
That is a good question, I wouldn't think it would make much of a difference
so it's probably ok.
@keith-turner any thoughts on if leaving volatile when currently not needed
is a big deal performance penalty wise?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
