keith-turner commented on code in PR #4558:
URL: https://github.com/apache/accumulo/pull/4558#discussion_r1608649312
##########
server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java:
##########
@@ -164,9 +167,10 @@ public long getDataSourceDeletions() {
}
private enum CloseState {
- OPEN, CLOSING, CLOSED, COMPLETE
+ OPEN, REQUESTED, CLOSING, CLOSED, COMPLETE
}
+ private volatile long closeRequestTime = 0;
Review Comment:
Would guess its probably not a performance penalty as synchronized block
ensure memory consistency. If the variable is only accessed in a sync block I
usually do not make it volatile because to me volatile implies its ok to access
outside of a synch block. If two or more volatile variables are dependent on
each other then accessing outside of a synch block is very tricky and should
probably be avoided. Volatile is best for independent variables that are safe
to access outside of synch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
