dlmarion commented on PR #4535: URL: https://github.com/apache/accumulo/pull/4535#issuecomment-2140678310
> To find the code, they would likely need to find the name (without the prefix) to find the constant name and then find where the constant name is used. The constant name will not show up directly in the metrics as reported, any logs or in a jstack. I agree. With this change, if a user is looking at the metric `accumulo.pool.batch.writer.send`, they can find the corresponding thread in the jstack with the same name, but to find the place in the code where it's being created and used they have to look for `batch.writer.send`. I'm suggesting that maybe we can make this easier by creating named constants and use them everywhere. We already have some of them in a file, but only those that are used for metrics. If we created an Enum for the thread pool names, and made it such that the ThreadPoolBuilder object only accepted an enum, then it would force all future thread pools to follow the same pattern. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
