dlmarion commented on code in PR #4535:
URL: https://github.com/apache/accumulo/pull/4535#discussion_r1619340058
##########
core/src/main/java/org/apache/accumulo/core/clientImpl/ClientContext.java:
##########
@@ -260,18 +261,20 @@ public Ample getAmple() {
submitScannerReadAheadTask(Callable<List<KeyValue>> c) {
ensureOpen();
if (scannerReadaheadPool == null) {
- scannerReadaheadPool = clientThreadPools.getPoolBuilder("Accumulo
scanner read ahead thread")
+ scannerReadaheadPool = clientThreadPools
+ .getPoolBuilder(METRICS_POOL_PREFIX +
"client.context.scanner.read.ahead")
Review Comment:
IMO, the metric names should reflect the function without the location. The
location of the metric is emitted as the process name tag. For the client, none
of these metrics will be emitted unless the user wires up Micrometer in their
client.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
