keith-turner commented on code in PR #4628:
URL: https://github.com/apache/accumulo/pull/4628#discussion_r1626432634
##########
server/compactor/src/main/java/org/apache/accumulo/compactor/Compactor.java:
##########
@@ -490,23 +500,22 @@ protected CompactionCoordinatorService.Client
getCoordinatorClient() throws TTra
* @param err reference to error
* @return Runnable compaction job
*/
- protected Runnable createCompactionJob(final TExternalCompactionJob job,
+ protected FileCompactorRunnable createCompactionJob(final
TExternalCompactionJob job,
Review Comment:
Feel free to ignore this comment because not sure if this would actually
work or if its better, was just something I was thinking about. The compactor
AtomicRef could be passed into this method and the method could return a
runnable like it used to and the when the runnable is run it would eventually
set the FileCompactor obj on the atomic ref. If it did work then may not need
the initialize method.
```java
protected Runnable createCompactionJob(final TExternalCompactionJob job,
final LongAdder totalInputEntries, final LongAdder totalInputBytes,
final CountDownLatch started, final CountDownLatch stopped,
final AtomicReference<Throwable> err, final
AtomicReference<FileCompactor> fcr) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
