dlmarion commented on code in PR #4628:
URL: https://github.com/apache/accumulo/pull/4628#discussion_r1626444326
##########
server/compactor/src/main/java/org/apache/accumulo/compactor/Compactor.java:
##########
@@ -490,23 +500,22 @@ protected CompactionCoordinatorService.Client
getCoordinatorClient() throws TTra
* @param err reference to error
* @return Runnable compaction job
*/
- protected Runnable createCompactionJob(final TExternalCompactionJob job,
+ protected FileCompactorRunnable createCompactionJob(final
TExternalCompactionJob job,
Review Comment:
I'm inclined to leave as-is, but only because it's working. I was having an
internal struggle on the best approach, and I think the code is probably due
for a cleanup and/or refactor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
