ddanielr commented on code in PR #4682:
URL: https://github.com/apache/accumulo/pull/4682#discussion_r1644640310
##########
server/base/src/main/java/org/apache/accumulo/server/metadata/ServerAmpleImpl.java:
##########
@@ -377,14 +377,11 @@ public void deleteScanServerFileReferences(String
serverAddress, UUID scanServer
Objects.requireNonNull(scanServerLockUUID, "Server uuid must be supplied");
try (
Scanner scanner = context.createScanner(DataLevel.USER.metaTable(),
Authorizations.EMPTY)) {
- scanner.setRange(ScanServerFileReferenceSection.getRange());
- scanner.fetchColumn(new Text(serverAddress), new
Text(scanServerLockUUID.toString()));
+ scanner
+ .setRange(new Range(ScanServerFileReferenceSection.getRowPrefix() +
scanServerLockUUID));
Review Comment:
We don't need to write the old mutation style for puts, just for putDeletes.
This code path is only called from the ScanServer when removing its own UUID
reference on shutdown.
Any Scan Servers that are writing the old mutation style are running an
older version of accumulo code and wouldn't be using this code path.
We only need to look in both places for the manager code's cleanup operation
(ScanServerMetadataEntries) since it compares the UUID of the ref against the
current UUID pool in ZK and then generates a set of refs to delete.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
