keith-turner commented on code in PR #4524:
URL: https://github.com/apache/accumulo/pull/4524#discussion_r1662972726
##########
core/src/main/java/org/apache/accumulo/core/fate/Fate.java:
##########
@@ -313,6 +317,26 @@ private void undo(FateId fateId, Repo<T> op) {
}
+ /**
+ * A thread that finds reservations held by dead processes and unreserves
them. Only one thread
+ * runs per store type across all Fate instances (one to clean up dead
reservations for
+ * {@link org.apache.accumulo.core.fate.user.UserFateStore UserFateStore}
and one to clean up dead
+ * reservations for {@link MetaFateStore}).
+ */
+ private class DeadReservationCleaner implements Runnable {
+ // TODO 4131 periodic check runs every 30 seconds
+ // Should this be longer? Shorter? A configurable Property? A function of
something?
+ private static final long INTERVAL_MILLIS = 30_000;
+
+ @Override
+ public void run() {
+ while (keepRunning.get()) {
+ store.deleteDeadReservations();
Review Comment:
That would be good to open a follow on issue about making all of the fate
threads critical.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
