keith-turner commented on code in PR #4524:
URL: https://github.com/apache/accumulo/pull/4524#discussion_r1671308191
##########
core/src/main/java/org/apache/accumulo/core/logging/FateLogger.java:
##########
@@ -175,6 +176,21 @@ public Optional<FateTxStore<T>> createAndReserve(FateKey
fateKey) {
}
return txStore;
}
+
+ @Override
+ public boolean isReserved(FateId fateId) {
+ return store.isReserved(fateId);
+ }
+
+ @Override
+ public Map<FateId,FateReservation> getActiveReservations() {
+ return store.getActiveReservations();
+ }
+
+ @Override
+ public void deleteDeadReservations() {
+ store.deleteDeadReservations();
Review Comment:
Not sure if this is workable, maybe the method could take a consumer that
is passes found dead reservations to like :
`deleteDeadReservations(Consumer<FateReservation> foundDead)` then this could
add logging for those. Alternatively could just put the same log stmts in each
impl of the store.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
