dlmarion commented on code in PR #4735:
URL: https://github.com/apache/accumulo/pull/4735#discussion_r1672778497
##########
core/src/main/java/org/apache/accumulo/core/data/Key.java:
##########
@@ -807,6 +807,19 @@ public ByteSequence getColumnVisibilityData() {
return new ArrayByteSequence(colVisibility);
}
+ /**
+ * Writes the column visibility into the given
<code>ArrayByteSequence</code>. This method gives
+ * users control over allocation of ArrayByteSequence objects by copying
into the passed in
+ * ArrayByteSequence.
+ *
+ * @param cv <code>ArrayByteSequence</code> object to copy into
+ * @return the <code>ArrayByteSequence</code> that was passed in
Review Comment:
Addressed in a0cc0d7
##########
core/src/main/java/org/apache/accumulo/core/data/ArrayByteSequence.java:
##########
@@ -154,6 +154,15 @@ public int offset() {
return offset;
}
+ /**
+ * Reset the backing array for this byte sequence object. This is useful for
object re-use.
+ */
+ public void reset(byte[] data) {
+ this.data = data;
+ this.offset = 0;
+ this.length = data.length;
Review Comment:
Addressed in a0cc0d7
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
