keith-turner commented on code in PR #4746:
URL: https://github.com/apache/accumulo/pull/4746#discussion_r1688302914
##########
server/base/src/main/java/org/apache/accumulo/server/conf/TableConfiguration.java:
##########
@@ -144,7 +146,7 @@ public ParsedIteratorConfig
getParsedIteratorConfig(IteratorScope scope) {
private static ScanDispatcher createScanDispatcher(AccumuloConfiguration
conf,
ServerContext context, TableId tableId) {
ScanDispatcher newDispatcher =
Property.createTableInstanceFromPropertyName(conf,
- Property.TABLE_SCAN_DISPATCHER, ScanDispatcher.class, null);
+ Property.TABLE_SCAN_DISPATCHER, ScanDispatcher.class, new
SimpleScanDispatcher());
Review Comment:
If we can not load the class for some reason, it would be good to fail here
instead of reverting to the default impl because as mention in a comment
elsewhere this can hide problems. Not sure the following is the best way to do
that with the wider changes being made.
```suggestion
Property.TABLE_SCAN_DISPATCHER, ScanDispatcher.class, null);
Objects.requireNonNull(newDispatcher);
```
##########
server/base/src/main/java/org/apache/accumulo/server/conf/TableConfiguration.java:
##########
@@ -175,8 +177,9 @@ public ServiceEnvironment getServiceEnv() {
private static CompactionDispatcher
createCompactionDispatcher(AccumuloConfiguration conf,
ServerContext context, TableId tableId) {
- CompactionDispatcher newDispatcher =
Property.createTableInstanceFromPropertyName(conf,
- Property.TABLE_COMPACTION_DISPATCHER, CompactionDispatcher.class,
null);
+ CompactionDispatcher newDispatcher =
+ Property.createTableInstanceFromPropertyName(conf,
Property.TABLE_COMPACTION_DISPATCHER,
+ CompactionDispatcher.class, new SimpleCompactionDispatcher());
Review Comment:
```suggestion
CompactionDispatcher.class, null);
Objects.requireNonNull(newDispatcher);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
