ctubbsii commented on code in PR #4746:
URL: https://github.com/apache/accumulo/pull/4746#discussion_r1688629301
##########
core/src/main/java/org/apache/accumulo/core/conf/ConfigurationTypeHelper.java:
##########
@@ -180,6 +180,8 @@ public static <T> T getClassInstance(String context, String
clazzName, Class<T>
if (instance == null && defaultInstance != null) {
log.info("Using default class {}", defaultInstance.getClass().getName());
instance = defaultInstance;
+ } else if (instance == null) {
+ log.info("Default instance not supplied, returning null");
Review Comment:
This could be collapsed with the previous case, to simplify the logic:
```java
if (instance == null) {
log.info("Using default class ({})",
defaultInstance == null ? null :
defaultInstance.getClass().getName());
instance = defaultInstance;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
