ddanielr commented on code in PR #4768:
URL: https://github.com/apache/accumulo/pull/4768#discussion_r1693580071
##########
core/src/main/java/org/apache/accumulo/core/clientImpl/ConditionalWriterImpl.java:
##########
@@ -375,7 +376,7 @@ private TabletServerMutations<QCMutation> dequeue(String
location) {
this.auths = config.getAuthorizations();
this.ve = new VisibilityEvaluator(config.getAuthorizations());
this.threadPool = context.threadPools().createScheduledExecutorService(
- config.getMaxWriteThreads(), this.getClass().getSimpleName());
Review Comment:
I didn't see any place where `this.getClass().getSimpleName` would change
it's value so I switched it to a constant value.
If there is different behavior here I'm happy to switch it back.
##########
core/src/main/java/org/apache/accumulo/core/clientImpl/ConditionalWriterImpl.java:
##########
@@ -375,7 +376,7 @@ private TabletServerMutations<QCMutation> dequeue(String
location) {
this.auths = config.getAuthorizations();
this.ve = new VisibilityEvaluator(config.getAuthorizations());
this.threadPool = context.threadPools().createScheduledExecutorService(
- config.getMaxWriteThreads(), this.getClass().getSimpleName());
Review Comment:
I didn't see any place where `this.getClass().getSimpleName` would change
its value so I switched it to a constant value.
If there is different behavior here I'm happy to switch it back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
