ddanielr commented on code in PR #4768:
URL: https://github.com/apache/accumulo/pull/4768#discussion_r1693581745
##########
core/src/main/java/org/apache/accumulo/core/clientImpl/bulk/BulkImport.java:
##########
@@ -483,13 +484,13 @@ private SortedMap<KeyExtent,Bulk.Files>
computeMappingFromFiles(FileSystem fs, T
if (this.executor != null) {
executor = this.executor;
} else if (numThreads > 0) {
- executor = service =
context.threadPools().getPoolBuilder("client.bulk.load")
+ executor = service =
context.threadPools().getPoolBuilder(BULK_IMPORT_CLIENT_LOAD_POOL_NAME)
.numCoreThreads(numThreads).enableThreadPoolMetrics().build();
} else {
String threads =
context.getConfiguration().get(ClientProperty.BULK_LOAD_THREADS.getKey());
executor = service = context.threadPools()
- .getPoolBuilder(
- METRICS_BULK_IMPORT_CLIENT_PREFIX +
ClientProperty.BULK_LOAD_THREADS.getKey())
Review Comment:
Is it important that we append `bulk.threads` to this thread pool?
If not, this could also switch to being a constant.
##########
core/src/main/java/org/apache/accumulo/core/clientImpl/bulk/BulkImport.java:
##########
@@ -483,13 +484,13 @@ private SortedMap<KeyExtent,Bulk.Files>
computeMappingFromFiles(FileSystem fs, T
if (this.executor != null) {
executor = this.executor;
} else if (numThreads > 0) {
- executor = service =
context.threadPools().getPoolBuilder("client.bulk.load")
+ executor = service =
context.threadPools().getPoolBuilder(BULK_IMPORT_CLIENT_LOAD_POOL_NAME)
.numCoreThreads(numThreads).enableThreadPoolMetrics().build();
} else {
String threads =
context.getConfiguration().get(ClientProperty.BULK_LOAD_THREADS.getKey());
executor = service = context.threadPools()
- .getPoolBuilder(
- METRICS_BULK_IMPORT_CLIENT_PREFIX +
ClientProperty.BULK_LOAD_THREADS.getKey())
Review Comment:
Is it important that we append `bulk.threads` to this thread pool by
referencing the client property?
If not, this could also switch to being a constant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
