DomGarguilo commented on code in PR #4821:
URL: https://github.com/apache/accumulo/pull/4821#discussion_r1727666859


##########
core/src/main/java/org/apache/accumulo/core/clientImpl/ClientTabletCacheImpl.java:
##########
@@ -889,7 +889,8 @@ protected CachedTablet _findTablet(ClientContext context, 
Text row, boolean skip
     }
 
     if (tl == null || (locationNeed == LocationNeed.REQUIRED && 
tl.getTserverLocation().isEmpty()
-        && tl.getCreationTime().compareTo(cacheCutoff) < 0)) {
+        && tl.getCreationTimestamp() - cacheCutoffTimestamp < 0)) {

Review Comment:
   The comparison of two `System.nanoTime()`s is the main reason these new 
timer objects were created in the first place so I am hoping there is a good 
way to refactor this to use one of the timer objects or eventually add 
functionality to avoid this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to