keith-turner commented on code in PR #4821:
URL: https://github.com/apache/accumulo/pull/4821#discussion_r1727979254
##########
core/src/main/java/org/apache/accumulo/core/clientImpl/ClientTabletCacheImpl.java:
##########
@@ -889,7 +889,8 @@ protected CachedTablet _findTablet(ClientContext context,
Text row, boolean skip
}
if (tl == null || (locationNeed == LocationNeed.REQUIRED &&
tl.getTserverLocation().isEmpty()
- && tl.getCreationTime().compareTo(cacheCutoff) < 0)) {
+ && tl.getCreationTimestamp() - cacheCutoffTimestamp < 0)) {
Review Comment:
> Some tests were failing with the exact syntax that you suggested even
though it looks good to me.
Ah, I had it backwards. Should be
`tl.getCreationTimer().hasElapsed(cacheCutoff.elapsed())` which is equivalent
to the change you made.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
