keith-turner commented on code in PR #4845:
URL: https://github.com/apache/accumulo/pull/4845#discussion_r1734954153


##########
core/src/main/java/org/apache/accumulo/core/clientImpl/InstanceOperationsImpl.java:
##########
@@ -273,24 +283,35 @@ public boolean testClassLoad(final String className, 
final String asTypeName)
   @Override
   public List<ActiveCompaction> getActiveCompactions(String tserver)
       throws AccumuloException, AccumuloSecurityException {
-    final var parsedTserver = HostAndPort.fromString(tserver);
-    Client client = null;
-    try {
-      client = getClient(ThriftClientTypes.TABLET_SERVER, parsedTserver, 
context);
+    final var serverHostAndPort = HostAndPort.fromString(tserver);
 
-      List<ActiveCompaction> as = new ArrayList<>();
-      for (var tac : client.getActiveCompactions(TraceUtil.traceInfo(), 
context.rpcCreds())) {
-        as.add(new ActiveCompactionImpl(context, tac, parsedTserver, 
CompactionHost.Type.TSERVER));
+    final List<ActiveCompaction> as = new ArrayList<>();
+    try {
+      if (getTabletServers().contains(tserver)) {

Review Comment:
   Not sure if it possible because it depends on the ZK schema.  Wondering if 
we could just see if the specific tserver exist in zoocache.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to