keith-turner commented on code in PR #4845:
URL: https://github.com/apache/accumulo/pull/4845#discussion_r1735183752
##########
core/src/main/java/org/apache/accumulo/core/clientImpl/ClientContext.java:
##########
@@ -1124,4 +1125,12 @@ public synchronized ThriftTransportPool
getTransportPool() {
return thriftTransportPool;
}
+ public synchronized ZookeeperLockChecker getZKLockChecker() {
Review Comment:
When I first saw this i thought it could check any lock (like the manager or
gc process) . It seems limited to just tablet server locks when looking deeper
though. Could make this name reflect this so when someone is looking at client
context methods its more apparent w/ further digging.
```suggestion
public synchronized ZookeeperLockChecker getTserverLockChecker() {
```
##########
core/src/main/java/org/apache/accumulo/core/clientImpl/InstanceOperationsImpl.java:
##########
@@ -273,24 +283,35 @@ public boolean testClassLoad(final String className,
final String asTypeName)
@Override
public List<ActiveCompaction> getActiveCompactions(String tserver)
Review Comment:
Could drop the `t` in the variable name.
```suggestion
public List<ActiveCompaction> getActiveCompactions(String server)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
