ctubbsii commented on code in PR #4881:
URL: https://github.com/apache/accumulo/pull/4881#discussion_r1757651317
##########
server/monitor/src/main/java/org/apache/accumulo/monitor/util/logging/RecentLogs.java:
##########
@@ -38,52 +41,44 @@ public class RecentLogs {
private static final int MAX_LOGS = 50;
+ private final Cache<String,DedupedEvent> eventsCache =
+ Caffeine.newBuilder().maximumSize(MAX_LOGS).build();
+ private final ConcurrentMap<String,DedupedEvent> events =
eventsCache.asMap();
Review Comment:
Is this a snapshot or merely a wrapped view? Would it make sense to remove
this and have the methods that call it operate directly on the eventsCache
object, and only call `.asMap()` when they need to?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
