dlmarion commented on code in PR #5012:
URL: https://github.com/apache/accumulo/pull/5012#discussion_r1813949456
##########
core/pom.xml:
##########
@@ -412,6 +416,37 @@
</plugins>
</build>
<profiles>
+ <profile>
+ <id>flatbuffers</id>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>com.sequsoft.maven.plugins</groupId>
+ <artifactId>flatbuffers-maven-plugin</artifactId>
Review Comment:
The reason I'm using Flatbuffers vs Thrift is for the reason I mentioned in
my initial comment - memory and time efficiency. IIRC, and I'm on my phone so I
can't easily check, Thrift fully deserializes the the binary sent over the
wire. Flatbuffers does not, it deserializes what you need when you need it.
Deserializing all of the metrics from the servers would create a lot of objects
which may potentially go unused if nobody is using the UI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
