dlmarion commented on code in PR #5012:
URL: https://github.com/apache/accumulo/pull/5012#discussion_r1815644008


##########
core/pom.xml:
##########
@@ -412,6 +416,37 @@
     </plugins>
   </build>
   <profiles>
+    <profile>
+      <id>flatbuffers</id>
+      <build>
+        <plugins>
+          <plugin>
+            <groupId>com.sequsoft.maven.plugins</groupId>
+            <artifactId>flatbuffers-maven-plugin</artifactId>

Review Comment:
   You had mentioned the flatbuffers-maven-plugin in an earlier comment and I 
didn't address it. I have no issue with removing it and using the same 
mechanism that we use for generating the Thrift code. I added the plugin 
because it was the easiest way to solve the problem and continue moving forward 
on this idea.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to