keith-turner commented on code in PR #5031:
URL: https://github.com/apache/accumulo/pull/5031#discussion_r1847130040
##########
core/src/main/java/org/apache/accumulo/core/fate/user/schema/FateSchema.java:
##########
@@ -65,4 +60,20 @@ public static class RepoColumnFamily {
public static final Text NAME = new Text(STR_NAME);
}
+ public static class StatusColumnFamily {
+ public static final String STR_NAME = "status";
+ public static final Text NAME = new Text(STR_NAME);
+
+ public static final String STATUS = "status";
+ public static final ColumnFQ STATUS_COLUMN = new ColumnFQ(NAME, new
Text(STATUS));
+ }
+
+ public static class ReservationColumnFamily {
+ public static final String STR_NAME = "reservation";
+ public static final Text NAME = new Text(STR_NAME);
+
+ public static final String RESERVATION = "reservation";
+ public static final ColumnFQ RESERVATION_COLUMN = new ColumnFQ(NAME, new
Text(RESERVATION));
+ }
Review Comment:
Could put these two columns in a single column family, that avoids the
duplication in family and qualifier. Some possible name for the family are
`txtAdmin`, `txMgmt`, or `txSituation`. Tried admin in the suggestion below
because was thinking this is information related to administering a fate
transaction.
```suggestion
public static class TxAdminColumnFamily {
public static final String STR_NAME = "txAdmin";
public static final Text NAME = new Text(STR_NAME);
public static final String STATUS = "status";
public static final ColumnFQ STATUS_COLUMN = new ColumnFQ(NAME, new
Text(STATUS));
public static final String RESERVATION = "reservation";
public static final ColumnFQ RESERVATION_COLUMN = new ColumnFQ(NAME, new
Text(RESERVATION));
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
