ddanielr commented on code in PR #5111: URL: https://github.com/apache/accumulo/pull/5111#discussion_r1857472121
########## assemble/conf/default-group-env.sh: ########## @@ -0,0 +1,70 @@ +#! /usr/bin/env bash +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# https://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +# This script will export ACCUMULO_JAVA_OPTS and PROPERTY_OVERRIDES variables based +# on the service type for the default resource group. Additional files can be created +# based on the groups configured in cluster.yaml. The contents of ACCUMULO_JAVA_OPTS +# will be appended to the JAVA_OPTS variable that is created in accumulo-env.sh, allowing +# the user to override any setting for this resource group. Likewise, the contents of +# PROPERTY_OVERRIDES will be appended to the arguments provided to the server class +# allowing the user to override any Accumulo property for this resource group. Overriding +# the bind address and group name properties would not be advisable as this could lead +# to deployment issues. +# +# Examples: +# +# Override JVM args +# export ACCUMULO_JAVA_OPTS="-Xms1024m -Xmx1024m" +# +# Override Accumulo properties +# export PROPERTY_OVERRIDES=('-o' 'rpc.backlog=1000' -o' 'tserver.hold.time.max=10m') Review Comment: Missing a quote in your example ```suggestion # export PROPERTY_OVERRIDES=('-o' 'rpc.backlog=1000' '-o' 'tserver.hold.time.max=10m') ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
