ctubbsii commented on code in PR #5111: URL: https://github.com/apache/accumulo/pull/5111#discussion_r1863811722
########## assemble/conf/default-group-env.sh: ########## Review Comment: > However, they are tied to the accumulo-service script, not accumulo-cluster. In my mind, those are part of the same cluster-management suite of config/scripts, so that doesn't seem like much of a distinction to me, but I understand you to mean that because `accumulo-service` can be used by itself without the cluster script or config file, these new files should stay somewhere common to both scripts if they end up getting moved. Thinking about the use case where `accumulo-service` is used without the cluster script or cluster config file, I'm slightly less inclined to suggest moving these. However, I'm still a little dissatisfied with the possibility of an unbounded growth (because the number of resource groups is not bounded) cluttering the main config directory, and the fact that because of the file naming convention, they won't be ordered such that they will be grouped together (most UIs and CLI tools to inspect directories do so by ordering the contents by name by default). That can make inspection of the config directory quite frustrating, when you have a bunch of these files interleaved with the other files there. I'm also wondering if this capability is already possible (or nearly possible, with slight tweaks) using the existing accumulo-env.sh, which optionally could source additional files, if the user wanted to break it out by resource group, without hard-coding that behavior and file naming conventions into that script. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
