ctubbsii commented on code in PR #5174: URL: https://github.com/apache/accumulo/pull/5174#discussion_r1888384220
########## assemble/conf/accumulo.properties: ########## @@ -31,3 +31,8 @@ instance.secret=DEFAULT ## Set to false if 'accumulo-util build-native' fails tserver.memory.maps.native.enabled=true + +## (optional) include additional property files for a resource group +## based on the ACCUMULO_RESOURCE_GROUP env var set in accumulo-service Review Comment: This is backported word-for-word from the main branch. Nothing in the comment says anything about which server types the accumulo-service script will set it for. In fact, accumulo-cluster and accumulo-service aren't really well documented at all, regarding what kinds of environment variables they make use of or set when launching processes. I don't think the shortcoming is the docs for this comment, but rather the lack of docs on accumulo-service in general. That's not something that I intend to solve with this PR, though. Also, note that tservers do get the "default" resource group, just like any other service type that does not have the ability to specify resource groups in cluster.yaml (manager, gc, coordinator, monitor). This is also implied by the contents of accumulo-env.sh If this comment were to change, I'd drop the mention of accumulo-service entirely, and simply say something like: "the following lines demonstrate the ability to organize properties into different files, named according to an environment variable; see commons-configuration documentation for details on property interpolation and include directives". After all, the commented out examples are not specific to accumulo-cluster or accumulo-service, or any other script. It's just a general feature that users can take advantage of if they have scripts that set environment variables. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
