ctubbsii commented on PR #5174:
URL: https://github.com/apache/accumulo/pull/5174#issuecomment-2558295729

   In these latest changes, I added colorized output to make it prettier, and 
fixed a few things with argument parsing. I noticed that `--all` had some 
problems, so I just removed it. I think it's better without. But it can be 
added back in pretty easily if we want to... we just need to decide on more 
concrete behavior for it. There's also somethings we can do to lock down 
repeated options, like calling different servers types with different groups... 
because right now, the latest one takes precedence. (Previous to these changes, 
the latest would take precedence, *except* if you specified all servers of that 
type by omitting the group name, in which case, the earlier one that had the 
group name present would take precedence, which was very confusing and weird).
   
   Also, there's a lot of logic that's intertwined with accumulo-service, and 
accumulo-service is clobbering the console with things that the 
accumulo-cluster script was trying to make nice.... like accumulo-service now 
prints a bunch of stuff that gets in the way of the progress dots in 
accumulo-cluster for starting tservers. Also, if we're going to do the progress 
dots, it should probably be done generally, not just for tservers. (like maybe 
scan servers and compactors, too?)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to