ctubbsii commented on code in PR #5192:
URL: https://github.com/apache/accumulo/pull/5192#discussion_r1888914627
##########
core/src/main/java/org/apache/accumulo/core/fate/ZooStore.java:
##########
@@ -523,7 +526,7 @@ public long timeCreated(long tid) {
verifyReserved(tid);
try {
- Stat stat = zk.getZooKeeper().exists(getTXPath(tid), false);
+ Stat stat = zk.exists(getTXPath(tid), false);
Review Comment:
ZRW.exists only returns boolean, not the Stat object used by this code to
return the timeCreated. I didn't convert any of this code to use ZRW instead of
ZK or ZK instead of ZRW... all I did was pass them in more sanely so that
instead of receiving a ZRW (first class citizen) and then the code trying to
peek at its internals to get the ZK object it needed, we pass in a ZK object
directly and it decorates it for its own internal convenience, when it wants to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
