ctubbsii commented on code in PR #5192: URL: https://github.com/apache/accumulo/pull/5192#discussion_r1888926612
########## core/src/main/java/org/apache/accumulo/core/fate/zookeeper/ZooCache.java: ########## Review Comment: That seems reasonable, but I think it's outside the scope of these changes. I don't think any of these changes have new occurrences of calling clear. However, I may have reused the existing ZooCache from the Context in a few places. If this is likely to cause a problem, I can back those out of these changes. My intent here wasn't to reuse ZooCache instances... but to make initializing them more maintainable, and to be able to better manage the lifecycle of the ZooKeeper they were built around. I think it'd be a good idea to backport that ZooCache improvement to 3.1 for that, though, if there is a concern about the `clear()` method. It's just out of scope for what I'm trying to do here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
