cshannon commented on code in PR #5187:
URL: https://github.com/apache/accumulo/pull/5187#discussion_r1894275850
##########
core/src/main/java/org/apache/accumulo/core/metadata/schema/Ample.java:
##########
@@ -392,6 +393,8 @@ interface TabletUpdates<T> {
T putCloned();
+ T putTabletMergeability(TabletMergeability tabletMergeability);
Review Comment:
My original plan was to persist everything as one value by adding the
current manager time to the value. So basically to compute the mergability
duration you would read the current SteadyTime then add the offset to it and
store it and then later you could compare to the current time by taking a diff.
However, I was thinking more about it and I think that storing it as two
separate values makes sense because it allows you to do better debugging
(logigng) plus you can see extra information such as when the value was
created. It also allows doing other things like update/replacing the original
SteadyTime, etc and other metric calculations if we keep it separate so I'll
change it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
